Merged
Conversation
while True: pass uses 100% cpu, which might be why we have a problem in CI on Windows
don't reset execution state to starting when we start watching, that's likely invalid and overrides a valid value
Contributor
Author
|
ok, I think I know what it is: the kernel The kernel connection waits for its iopub channel to be fully connected via the nudge mechanism to resolve this same issue, but since it's not applied to the So what happens:
If we include checking |
should avoid starting test when execution_state is not responding
Contributor
Author
|
@krassowski I think this may have fixed Windows CI (at least one pass), by making sure the |
krassowski
approved these changes
Feb 13, 2026
Collaborator
krassowski
left a comment
There was a problem hiding this comment.
Amazing, it does fix the CI 🎉 Thank you!
0468315 to
56b24e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while True: passuses 100% cpu, which might be why we have a problem in CI on Windows.Using
time.sleep()lets the main thread be blocked, but mostly idle, in case it's the main thread starving IO threads that could be the problem.